fix: _MACOSX directory in ootr archive can cause issues loading tracks #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenhl
added
Type: Bug
|
While we should add a failsafe on our end, does it not make a lot more sense to add shadow files from mac (or windows), like both of these, to the .gitignore of DJ so they are not committed in the first place? |
|
Unfortunately, the file exists within the .ootrs archive which is just a renamed zip, so a .gitignore won't catch it. Maybe a workflow could be added to unzip the archive and check for that on PR? |
|
ahh... that is a reoccuring thing though rarely. did merge that pr on our side. Damn Apple Users and bringing us issues. NotLikeThis |
fenhl
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Darunia's Joy discord, there was a user who was getting an error reading the .meta file for one of their songs.
I eventually figured out that it was because the ootrs archive also contained the author's
_MACOSXdir and a._<filename>.metathat was being read instead of the .meta file at the root.I think an easy way to fix this for future users, besides having authors making sure their ootrs archives only have files, is to add a check in Music.py so only root files are processed: